refactor: Updating template to support dark mode StatusBar on Android #33561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 472d531 |
Base commit: 472d531 |
|
@kacieb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @mrbrentkelly in 763dc52. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
backgroundColorprop to theStatusBarin the starter template so that Dark Mode is correctly demonstrated when running on Android.Before
StatusBar in starter app on Android would remain the same color no matter what the current device color scheme was.
After
StatusBar in starter app on Android correctly reacts to the color scheme.
Changelog
[Android] [Changed] - Demonstrating Dark Mode correctly in the
StatusBarfor the starter template App.Test Plan
This was a very simple change that I was able to verify in a newly generated RN project by copying the
backgroundColorprop across. See screenshots above.